On Mon, Apr 24, 2023 at 04:02:37PM -0400, John Snow wrote: > Several debian-based tests need the python3-venv dependency as a > consequence of Debian debundling the "ensurepip" module normally > included with Python. > > As mkvenv.py stands as of this commit, Debian requires EITHER: > > (A) setuptools and pip, or > (B) ensurepip > > mkvenv is a few seconds faster if you have setuptools and pip, so > developers should prefer the first requirement. For the purposes of CI, > the time-save is a wash; it's only a matter of who is responsible for > installing pip and when; the timing is about the same. > > Arbitrarily, I chose adding ensurepip to the test configuration because > it is normally part of the Python stdlib, and always having it allows us > a more consistent cross-platform environment.
python3-venv also matches the package that we already list in the lcitool auto generated dockerfiles, so that consistency is good. > > Signed-off-by: John Snow <js...@redhat.com> > --- > tests/docker/dockerfiles/debian-all-test-cross.docker | 3 ++- > tests/docker/dockerfiles/debian-hexagon-cross.docker | 3 ++- > tests/docker/dockerfiles/debian-riscv64-cross.docker | 3 ++- > tests/docker/dockerfiles/debian-tricore-cross.docker | 3 ++- > 4 files changed, 8 insertions(+), 4 deletions(-) Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
