On Thu, Apr 06, 2023 at 12:28:00PM +0200, Paolo Bonzini wrote: > There should be no paths from a coroutine_fn to aio_poll, however in > practice coroutine_mixed_fn will call aio_poll in the !qemu_in_coroutine() > path. By marking mixed functions, we can track accurately the call paths > that execute entirely in coroutine context, and find more missing > coroutine_fn markers. This results in more accurate checks that > coroutine code does not end up blocking. > > If the marking were extended transitively to all functions that call > these ones, static analysis could be done much more efficiently. > However, this is a start and makes it possible to use vrc's path-based > searches to find potential bugs where coroutine_fns call blocking functions. > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > include/io/channel.h | 78 ++++++++++++++++++++++---------------------- > io/channel.c | 78 ++++++++++++++++++++++---------------------- > 2 files changed, 78 insertions(+), 78 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
