On 4/10/23 13:24, Taylor Simpson wrote:
Most of these are not modelled in QEMU, so save the overhead of
calling a helper.

The only exception is dczeroa.  It assigns to hex_dczero_addr, which
is handled during packet commit.

Signed-off-by: Taylor Simpson<tsimp...@quicinc.com>
---
  target/hexagon/gen_tcg.h | 24 ++++++++++++++++++++++++
  target/hexagon/macros.h  | 18 ++++--------------
  2 files changed, 28 insertions(+), 14 deletions(-)

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>

Something to look at in the future: I believe quite a lot of these variables like dczero_addr are not "real" architectural state, in that they do not persist beyond the lifetime of the packet. There are others, e.g. pkt_has_store_s1.

These variables could be moved to DisasContext and allocated on demand. Even recently this was tedious, because of TCG temporary lifetime issues, but no longer.

Just a thought.


r~

Reply via email to