On Fri, Mar 17, 2023 at 06:50:18PM +0100, Hanna Czenczek wrote: > bdrv_pad_request() was the main user of qemu_iovec_init_extended(). > HEAD^ has removed that use, so we can remove qemu_iovec_init_extended() > now. > > The only remaining user is qemu_iovec_init_slice(), which can easily > inline the small part it really needs. > > Note that qemu_iovec_init_extended() offered a memcpy() optimization to > initialize the new I/O vector. qemu_iovec_concat_iov(), which is used > to replace its functionality, does not, but calls qemu_iovec_add() for > every single element. If we decide this optimization was important, we > will need to re-implement it in qemu_iovec_concat_iov(), which might > also benefit its pre-existing users. > > Signed-off-by: Hanna Czenczek <hre...@redhat.com> > --- > include/qemu/iov.h | 5 --- > util/iov.c | 79 +++++++--------------------------------------- > 2 files changed, 11 insertions(+), 73 deletions(-) >
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
