On Tue, 14 Feb 2023 at 16:32, Richard Henderson <richard.hender...@linaro.org> wrote: > > From: David Reiss <dre...@meta.com> > > Allow the function to be used outside of m_helper.c. > Move to be outside of ifndef CONFIG_USER_ONLY block. > Rename from get_v7m_sp_ptr. > > Signed-off-by: David Reiss <dre...@meta.com> > [rth: Split out of a larger patch] > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > target/arm/internals.h | 10 +++++ > target/arm/m_helper.c | 84 +++++++++++++++++++++--------------------- > 2 files changed, 51 insertions(+), 43 deletions(-)
Depending on the ifdeffery in patch 14, if all the callsites are inside ifndef CONFIG_USER_ONLY then we won't need to move the function definition. Otherwise: Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM