On Thu, 2 Feb 2023 at 21:12, Aaron Lindsay <aa...@os.amperecomputing.com> wrote: > > Signed-off-by: Aaron Lindsay <aa...@os.amperecomputing.com> > --- > target/arm/cpu.h | 5 +++ > target/arm/cpu64.c | 81 ++++++++++++++++++++++++++++++++++++++-------- > 2 files changed, 72 insertions(+), 14 deletions(-)
Do we really need all these properties ? Generally we don't add CPU properties unless there's a good reason for the user (or the board/SoC code) to want to flip them. The more usual case is that we simply enable them on the 'max' CPU by setting the ID register fields appropriately. Somewhere in this series you need to add documentation of the features being implemented to docs/system/arm/emulation.rst (just a one-liner per FEAT_whatever). thanks -- PMM
