On Wed, Feb 08, 2023 at 09:35:59AM +0000, Het Gala wrote: > 'migrate-incoming' QAPI design have been modified into well-defined > MigrateChannel struct to prevent multiple encoding of uri strings on > the destination side.'uri' parameter is kept for backward compatibility. > > Suggested-by: Daniel P. Berrange <berra...@redhat.com> > Suggested-by: Manish Mishra <manish.mis...@nutanix.com> > Suggested-by: Aravind Retnakaran <aravind.retnaka...@nutanix.com> > Signed-off-by: Het Gala <het.g...@nutanix.com> > --- > migration/migration-hmp-cmds.c | 8 +++++++- > migration/migration.c | 3 ++- > qapi/migration.json | 22 ++++++++++++++++++++-- > softmmu/vl.c | 2 +- > 4 files changed, 30 insertions(+), 5 deletions(-)
> +++ b/qapi/migration.json > @@ -1623,7 +1623,11 @@ > # with -incoming defer > # > # @uri: The Uniform Resource Identifier identifying the source or > -# address to listen on > +# the address to listen on > +# > +# @channel: Struct containing migration channel type, along with > +# all the details of the destination interface required > +# for the address to listen on for migration stream. Missing a '(since 8.0)' tag. > # > # Returns: nothing on success > # > @@ -1640,14 +1644,28 @@ > # > # 3. The uri format is the same as for -incoming > # > +# 4. The 'uri' and 'channel' arguments are mutually exclusive but, atleast > +# one of the two arguments should be present. Grammar: The 'uri' and 'channel' arguments are mutually exclusive; exactly one of the two should be present. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
