On Mon, Jan 30, 2023 at 01:24:51PM +0000, Jonathan Cameron wrote: > > > diff --git a/tests/qtest/cxl-test.c b/tests/qtest/cxl-test.c > > index e59ba22387..6893f54e28 100644 > > --- a/tests/qtest/cxl-test.c > > +++ b/tests/qtest/cxl-test.c > > @@ -40,32 +40,46 @@ > > "-device cxl-rp,id=rp2,bus=cxl.1,chassis=0,slot=2 " \ > > "-device cxl-rp,id=rp3,bus=cxl.1,chassis=0,slot=3 " > > > > -#define QEMU_T3D \ > > +#define QEMU_T3D_DEPRECATED \ > > "-object memory-backend-file,id=cxl-mem0,mem-path=%s,size=256M " \ > > - "-object memory-backend-file,id=lsa0,mem-path=%s,size=256M " \ > > + "-object memory-backend-file,id=lsa0,mem-path=%s,size=256M " \ > > "-device cxl-type3,bus=rp0,memdev=cxl-mem0,lsa=lsa0,id=cxl-pmem0 " > > > > +#define QEMU_T3D_PMEM \ > > + "-object memory-backend-file,id=m0,mem-path=%s,size=256M " \ > > + "-object memory-backend-file,id=lsa0,mem-path=%s,size=256M " \ > > + "-device cxl-type3,bus=rp0,persistent-memdev=cxl-m0,lsa=lsa0,id=pmem0 " > naming mismatch. I've fixed up with mem0 as the device name. > The naming isn't totally consistent so I may tweak this some more before > sending for upstream. > >
ack
