"Michael S. Tsirkin" <m...@redhat.com> writes: > On Thu, Jan 19, 2023 at 07:59:41AM +0100, Markus Armbruster wrote: >> When clean-includes claims to skip or ignore a file, only the part >> that sanitizes use of qemu/osdep.h skips the file. The part that >> looks for duplicate #include does not, and neither does committing to >> Git. >> >> The latter can get unrelated stuff included in the commit, but only if >> you run clean-includes in a dirty tree, which is unwise. Messed up >> when we added skipping in commit fd3e39a40c "scripts/clean-includes: >> Enhance to handle header files". >> >> The former can cause bogus reports for --check-dup-head. Added in >> commit d66253e46a "scripts/clean-includes: added duplicate #include >> check", duplicating the prior mistake. >> >> Fix the script to fully skip files. >> >> Fixes: fd3e39a40ca2ee26b09a5de3149af8b056b85233 >> Fixes: d66253e46ae2b9c36a9dd90b2b74c0dfa5804b22 > > Isn't > Fixes: %h (\"%s\") > > the accepted format for this?
It seems to be common these days. I'll adjust.
