Taylor Simpson <tsimp...@quicinc.com> writes: >> -----Original Message----- >> From: Markus Armbruster <arm...@redhat.com> >> Sent: Thursday, January 19, 2023 1:00 AM >> To: qemu-devel@nongnu.org >> Cc: richard.hender...@linaro.org; pbonz...@redhat.com; >> kw...@redhat.com; hre...@redhat.com; i...@bsdimp.com; >> kev...@freebsd.org; berra...@redhat.com; gr...@kaod.org; >> qemu_...@crudebyte.com; m...@redhat.com; phi...@linaro.org; >> peter.mayd...@linaro.org; alist...@alistair23.me; jasow...@redhat.com; >> jonathan.came...@huawei.com; kbast...@mail.uni-paderborn.de; >> quint...@redhat.com; dgilb...@redhat.com; michael.r...@amd.com; >> kkost...@redhat.com; Taylor Simpson <tsimp...@quicinc.com>; >> pal...@dabbelt.com; bin.m...@windriver.com; qemu-bl...@nongnu.org; >> qemu-...@nongnu.org; qemu-ri...@nongnu.org >> Subject: [PATCH v4 12/19] target/hexagon: Clean up includes >> >> Clean up includes so that osdep.h is included first and headers which it >> implies are not included manually. >> >> This commit was created with scripts/clean-includes. >> >> Changes to standalone programs dropped, because I can't tell whether them >> not using qemu/osdep.h is intentional: >> >> target/hexagon/gen_dectree_import.c >> target/hexagon/gen_semantics.c >> target/hexagon/idef-parser/idef-parser.h >> target/hexagon/idef-parser/parser-helpers.c >> target/hexagon/idef-parser/parser-helpers.h > > Correct. These are standalone programs not built with the full QEMU context.
I'll tweak the commit message like this: Changes to standalone programs dropped, because these intentionally don't use qemu/osdep.h: >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> --- >> target/hexagon/hex_arch_types.h | 1 - >> target/hexagon/mmvec/macros.h | 1 - >> 2 files changed, 2 deletions(-) > > Reviewed-by: Taylor Simpson <tsimp...@quicinc.com> Thanks!