Yes, the formatting is correct in patchew. I'll include these in my next PR.
Thanks, Taylor > -----Original Message----- > From: Mukilan Thiyagarajan (QUIC) <quic_mthiy...@quicinc.com> > Sent: Thursday, December 29, 2022 3:28 AM > To: Taylor Simpson <tsimp...@quicinc.com>; Mukilan Thiyagarajan (QUIC) > <quic_mthiy...@quicinc.com>; qemu-devel@nongnu.org; > laur...@vivier.eu > Cc: Brian Cain <bc...@quicinc.com>; richard.hender...@linaro.org; > alex.ben...@linaro.org > Subject: RE: [PATCH 1/2] linux-user/hexagon: fix signal context save & > restore > > >> + : : : "r7", "p0", "p1", "p2", "p3"); } > > Put the curly on the next line. > > Not sure if this issue is on my end or your mail client, but the formatting > appears to be correct in the patchew: > https://patchew.org/QEMU/20221227153447.2729-1- > quic._5fmthiy...@quicinc.com/20221227153447.2729-2- > quic._5fmthiy...@quicinc.com/ > > I've addressed the other review comments in v2: > https://patchew.org/QEMU/20221229092006.10709-1- > quic._5fmthiy...@quicinc.com/20221229092006.10709-2- > quic._5fmthiy...@quicinc.com/ > > Please let me know if the formatting is still off. > > Thanks, > Mukilan > > -----Original Message----- > From: Taylor Simpson <tsimp...@quicinc.com> > Sent: Wednesday, December 28, 2022 11:35 PM > To: Mukilan Thiyagarajan (QUIC) <quic_mthiy...@quicinc.com>; qemu- > de...@nongnu.org; laur...@vivier.eu > Cc: Brian Cain <bc...@quicinc.com>; richard.hender...@linaro.org; > alex.ben...@linaro.org > Subject: RE: [PATCH 1/2] linux-user/hexagon: fix signal context save & > restore > > > > > -----Original Message----- > > From: Mukilan Thiyagarajan (QUIC) <quic_mthiy...@quicinc.com> > > Sent: Tuesday, December 27, 2022 9:35 AM > > To: qemu-devel@nongnu.org; Taylor Simpson <tsimp...@quicinc.com>; > > laur...@vivier.eu > > Cc: Brian Cain <bc...@quicinc.com>; richard.hender...@linaro.org; > > alex.ben...@linaro.org; Mukilan Thiyagarajan (QUIC) > > <quic_mthiy...@quicinc.com> > > Subject: [PATCH 1/2] linux-user/hexagon: fix signal context save & > > restore > > > > diff --git a/tests/tcg/hexagon/signal_context.c > > b/tests/tcg/hexagon/signal_context.c > > new file mode 100644 > > index 0000000000..297e6915a4 > > --- /dev/null > > +++ b/tests/tcg/hexagon/signal_context.c > > @@ -0,0 +1,84 @@ > > +/* > > + * Copyright(c) 2019-2022 Qualcomm Innovation Center, Inc. All > > +Rights > > Since this is a new file, only list 2022 (not 2019-2022). > > > +void sig_user(int sig, siginfo_t *info, void *puc) { > > + asm("r7 = #0\n\t" > > + "p0 = r7\n\t" > > + "p1 = r7\n\t" > > + "p2 = r7\n\t" > > + "p3 = r7\n\t" > > + : : : "r7", "p0", "p1", "p2", "p3"); } > > Put the curly on the next line. > > > + > > +int main() > > +{ > > + > > + struct sigaction act; > > + struct itimerspec it; > > + timer_t tid; > > + struct sigevent sev; > > + act.sa_sigaction = sig_user; > > + sigemptyset(&act.sa_mask); > > + act.sa_flags = SA_SIGINFO; > > + sigaction(SIGUSR1, &act, NULL); > > + sev.sigev_notify = SIGEV_SIGNAL; > > + sev.sigev_signo = SIGUSR1; > > + sev.sigev_value.sival_ptr = &tid; > > + timer_create(CLOCK_REALTIME, &sev, &tid); > > + it.it_interval.tv_sec = 0; > > + it.it_interval.tv_nsec = 100000; > > + it.it_value.tv_sec = 0; > > + it.it_value.tv_nsec = 100000; > > + timer_settime(tid, 0, &it, NULL); > > + > > + int err = 0; > > + unsigned int i = 100000; > > Put these declarations at the beginning of the function before any code > > > + return err; > > Before return err, do puts(err ? "FAIL" : "PASS"); > > Otherwise > Reviewed-by: Taylor Simpson <tsimp...@quicinc.com> >
