On Mon, 9 Jan 2012, Gerd Hoffmann wrote:
Hi,
if (!pci_dev->qdev.hotplugged) {
static int loaded = 0;
- if (!loaded) {
+ if (!loaded &&
pci_has_not_explicitly_disabled_option_romfile(pci_dev)) {
rom_add_option("pxe-ne2k_pci.rom", -1);
loaded = 1;
}
I think you can just remove this altogether and add a .romfile = "..."
entry instead like it is done for the other nics.
I'm not sure about the consequences (hotplugging feature, etc.) when
changing it to romfile as in other PCI devices. Also the patch is more
generic and supports static and dynamic devices (hotplugable and possible
future devices). Patch supports without hotplugging both options to
disable the romfile:
,romfile=
,romfile=disabled
And the patch has already been tested ...
Therefore I suggest to commit it and maybe make a refactoring without
hotplugging later on.
Ciao,
Gerhard
--
http://www.wiesinger.com/
