> -----Original Message-----
> From: Philippe Mathieu-Daudé <phi...@linaro.org>
> Sent: Tuesday, December 20, 2022 8:20 AM
> To: Alessandro Di Federico <a...@rev.ng>
> Cc: Taylor Simpson <tsimp...@quicinc.com>; qemu-devel@nongnu.org;
> Paolo Montesel <bab...@rev.ng>; Anton Johansson <a...@rev.ng>;
> richard.hender...@linaro.org; peter.mayd...@linaro.org; Brian Cain
> <bc...@quicinc.com>; Matheus Bernardino (QUIC)
> <quic_mathb...@quicinc.com>; stefa...@redhat.com
> Subject: Re: [PULL 00/21] Hexagon update: bug fixes, performance, idef-
> parser
>
> On 20/12/22 13:51, Alessandro Di Federico wrote:
> > On Tue, 20 Dec 2022 08:30:02 +0100
> > Philippe Mathieu-Daudé <phi...@linaro.org> wrote:
> >
> >> Do we really need this level? IIUC the problem with -Wextra is using
> >> a newer compiler toolchain it can include warnings we haven't fixed.
> >> Maybe worthwhile but it can break from times to times.
> >
> > I think we just wanted to be overly zealous.
> > Flags typically used by QEMU are fine.
> >
> > Shall I send a patch to drop -Wextra?
>
> Well I think so, but meanwhile I'm surprised nobody else reported that, not
> even the CI.
What version of clang are you using? I tried 15.0.6, but just dropping the -W
extra didn't fix the problem. This worked for me
diff --git a/target/hexagon/meson.build b/target/hexagon/meson.build
index e8f250fcac..4dbceb7765 100644
--- a/target/hexagon/meson.build
+++ b/target/hexagon/meson.build
@@ -197,7 +197,7 @@ if idef_parser_enabled and 'hexagon-linux-user' in
target_dirs
idef_parser_dir / 'parser-helpers.c'],
include_directories: ['idef-parser', '../../include/'],
dependencies: [glib_dep],
- c_args: ['-Wextra'],
+ c_args: ['-Wno-unused-but-set-variable'],
native: true
)
Taylor
