On 20/12/22 00:19, Philippe Mathieu-Daudé wrote:
Hi,
On 16/12/22 21:48, Taylor Simpson wrote:
----------------------------------------------------------------
12-21)
Instruction definition parser (idef-parser) from rev.ng
Parses the instruction semantics and generates TCG
Building QEMU with Clang I'm now getting:
target/hexagon/idef-parser.p/idef-parser.tab.c:2197:9: error: variable
'yynerrs' set but not used [-Werror,-Wunused-but-set-variable]
int yynerrs = 0;
^
idef-parser.tab.c is built using:
193 idef_parser = executable(
194 'idef-parser',
195 [flex.process(idef_parser_dir / 'idef-parser.lex'),
196 bison.process(idef_parser_dir / 'idef-parser.y'),
197 idef_parser_dir / 'parser-helpers.c'],
198 include_directories: ['idef-parser', '../../include/'],
199 dependencies: [glib_dep],
200 c_args: ['-Wextra'],
^^^^^^^^
201 native: true
202 )
(see commit c0a41ee631 "target/hexagon: import parser for idef-parser")
Do we really need this level? IIUC the problem with -Wextra is using a
newer compiler toolchain it can include warnings we haven't fixed. Maybe
worthwhile but it can break from times to times.
Using '-Wextra -Wno-unused-but-set-variable' seems a hack. I guess I'd
simply remove -Wextra for simplicity, since no much value is added here.
Regards,
Phil.
