On Mon, Dec 19, 2022 at 8:15 AM Philippe Mathieu-Daudé <phi...@linaro.org> wrote: > > On 18/12/22 23:39, Strahinja Jankovic wrote: > > Hi, > > > > On Sun, Dec 18, 2022 at 11:23 PM Philippe Mathieu-Daudé > > <phi...@linaro.org> wrote: > >> > >> On 18/12/22 23:12, Strahinja Jankovic wrote: > >>> Hi, > >>> > >>> On Sun, Dec 18, 2022 at 11:07 PM Philippe Mathieu-Daudé > >>> <phi...@linaro.org> wrote: > >>>> > >>>> On 18/12/22 22:19, Strahinja Jankovic wrote: > >>>>> This patch adds minimal support for AXP-209 PMU. > >>>>> Most important is chip ID since U-Boot SPL expects version 0x1. Besides > >>>>> the chip ID register, reset values for two more registers used by A10 > >>>>> U-Boot SPL are covered. > >>>>> > >>>>> Signed-off-by: Strahinja Jankovic <strahinja.p.janko...@gmail.com> > >>>>> --- > >>>>> hw/arm/Kconfig | 1 + > >>>>> hw/misc/Kconfig | 4 + > >>>>> hw/misc/allwinner-axp-209.c | 238 > >>>>> ++++++++++++++++++++++++++++++++++++ > >>>>> hw/misc/meson.build | 1 + > >>>>> hw/misc/trace-events | 5 + > >>>>> 5 files changed, 249 insertions(+) > >>>>> create mode 100644 hw/misc/allwinner-axp-209.c > > > >>>>> +config ALLWINNER_AXP_209 > >>>> > >>>> This controller is not specific to AllWinner. It can be plugged on any > >>>> i2c bus. Please rename it AXP209_PMU. Otherwise LGTM! > >>> > >>> Do you mean only in Kconfig, or everywhere (file name, function names, > >>> etc.)? Thanks. > >> > >> Keeping the file / functions names with 'allwinner' would give the false > >> idea this is AllWinner specific; rather confusing isn't it? Besides it > >> is not part of the SoC, this is an external component sitting on the > >> bus. So "everywhere". > > > > I was expecting that answer, but I wanted to check :) > > When I started writing code for AXP209 it was indeed without allwinner > > prefix, but then checkpatch.pl complained about missing lines in > > MAINTAINERS. At that time it was easier to add the prefix (and get a > > match in MAINTAINERS) than to investigate if I should update the > > MAINTAINERS file or ignore the checkpatch.pl complaint. > > > > I will update everything related to AXP209 so it does not have the > > Allwinner prefix. > > Add a new AXP209 MAINTAINERS's section with your name :) Or add the new > file to the Allwinner-a10 section and add your name as designated > reviewer or co-maintainer :)
Thanks, I will take one of these suggested approaches. Best regards, Strahinja
