Hi, On Sun, Dec 18, 2022 at 11:07 PM Philippe Mathieu-Daudé <phi...@linaro.org> wrote: > > On 18/12/22 22:19, Strahinja Jankovic wrote: > > This patch adds minimal support for AXP-209 PMU. > > Most important is chip ID since U-Boot SPL expects version 0x1. Besides > > the chip ID register, reset values for two more registers used by A10 > > U-Boot SPL are covered. > > > > Signed-off-by: Strahinja Jankovic <strahinja.p.janko...@gmail.com> > > --- > > hw/arm/Kconfig | 1 + > > hw/misc/Kconfig | 4 + > > hw/misc/allwinner-axp-209.c | 238 ++++++++++++++++++++++++++++++++++++ > > hw/misc/meson.build | 1 + > > hw/misc/trace-events | 5 + > > 5 files changed, 249 insertions(+) > > create mode 100644 hw/misc/allwinner-axp-209.c > > > > diff --git a/hw/misc/Kconfig b/hw/misc/Kconfig > > index 052fb54310..3855d937fd 100644 > > --- a/hw/misc/Kconfig > > +++ b/hw/misc/Kconfig > > @@ -180,4 +180,8 @@ config ALLWINNER_A10_CCM > > config ALLWINNER_A10_DRAMC > > bool > > > > +config ALLWINNER_AXP_209 > > This controller is not specific to AllWinner. It can be plugged on any > i2c bus. Please rename it AXP209_PMU. Otherwise LGTM!
Do you mean only in Kconfig, or everywhere (file name, function names, etc.)? Thanks. Best regards, Strahinja > > > + bool > > + depends on I2C > > + > > source macio/Kconfig > > diff --git a/hw/misc/allwinner-axp-209.c b/hw/misc/allwinner-axp-209.c > > new file mode 100644 > > index 0000000000..cf79175034 > > --- /dev/null > > +++ b/hw/misc/allwinner-axp-209.c > > @@ -0,0 +1,238 @@ > > +/* > > + * AXP-209 Emulation > > + * > > + * Copyright (C) 2022 Strahinja Jankovic <strahinja.p.janko...@gmail.com>
