On 11 January 2012 04:12, Andreas Färber <afaer...@suse.de> wrote: > Am 10.01.2012 21:33, schrieb Mark Langsdorf: >> vmstate_register(&dev->qdev, -1, &vmstate_nvic, s); > > This should probably be removed now that you register it through > sysbus_register_withprop() below.
Oops, yes, missed that bit. > I'm still wondering whether the num-irq property calls for a version > bump somewhere. My thinking is no, since the SysBus device will not be > user-created from the command line and therefore effectively has the > same values as hardcoded before; but in that case we should assert this > by setting .qdev.no_user = 1. I agree that we should probably set no_user=1 on more of the ARM internal devices than we currently do, but I think that's probably a separate issue rather than one we should deal with in this patch. Re version-bump: my thinking was that one isn't required because the onus is on the user not to migrate between systems where the devices have had different qdev property values set. So as long as "no properties set to non default values" doesn't change then we're ok whether the user put the device on the command line or not. (In practice (a) any config with a user-created NVIC device is always broken because there's no way for the user to wire it up properly, and (b) another patch in this series is bumping the CPU state version number so migration is going to fail anyhow.) -- PMM
