On Fri, 21 Oct 2022 at 08:53, Marc-André Lureau
<marcandre.lur...@gmail.com> wrote:
> [...]
> Wouldn't it be simpler to modify the g_critical() in ga_channel_new() instead?
>
> if (!ga_channel_open(c, path, method, listen_fd, &err)) {
> g_critical("Failed to open %s: %s", path, error_get_pretty(err));
Sounds like a good idea -- it's a more central place.
However, I'm hesitant about doing that now:
* This patch just syncs channel-posix.c up with channel-win32.c.
* I don't have a way to test the windows code so I'd rather not touch
it (which I think one should do to keep the win32/posix files mostly
in sync).
* My test iteration time on this code is quite slow.
* I'm a noob -- first time submitter.
Can we merge as-is please?
/Bjørn
