at 1:37 PM, Klaus Jensen <i...@irrelevant.dk> wrote: > On Okt 21 10:37, Jinhao Fan wrote: >> at 7:35 PM, Klaus Jensen <i...@irrelevant.dk> wrote: >> >>> Commit 2e53b0b45024 ("hw/nvme: Use ioeventfd to handle doorbell >>> updates") had the unintended effect of disabling batching of CQEs. >>> >>> This patch changes the sq/cq timers to bottom halfs and instead of >>> calling nvme_post_cqes() immediately (causing an interrupt per cqe), we >>> defer the call. >> >> This change is definitely desired. >> >>> | iops >>> -----------------+------ >>> baseline | 138k >>> +cqe batching | 233k >> >> What is the queue depth config for this test? > > That's 64. My box isnt nearly as beefy as yours ;)
:). The improvement looks great. Reviewed-by: Jinhao Fan <fanjinhao...@ict.ac.cn>