On Mon, Oct 10, 2022 at 02:57:47PM +0100, Alberto Faria wrote: > On Thu, Oct 6, 2022 at 10:35 PM Stefan Hajnoczi <stefa...@redhat.com> wrote: > > @@ -620,15 +767,39 @@ static int blkio_file_open(BlockDriverState *bs, > > QDict *options, int flags, > > return ret; > > } > > > > + ret = blkio_get_bool(s->blkio, > > + "mem-regions-pinned", > > Should the property be named "may-pin-mem-regions" or similar? For > drivers like vhost-user we may not be able to determine for sure > whether memory regions will be pinned, and making that uncertainty > explicit in the name may be a good idea, for instance to ensure users > don't decide to rely on memory regions being pinned when the property > is true.
Sounds good to me. I'll change the property name in this patch and then send a libblkio patch that adds the property. Stefan
signature.asc
Description: PGP signature
