On Thu, 6 Oct 2022 at 16:13, Philippe Mathieu-Daudé via <qemu-devel@nongnu.org> wrote: > > Hi Michael, > > On 6/10/22 13:39, Michael S. Tsirkin wrote: > > The most commmon complaint about submodules is that > > Typo "common" > > > they don't follow when one switches branches in the > > main repo. Enable recursing into submodules by default > > to address that. > > > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > > --- > > .gitmodules | 23 +++++++++++++++++++++++ > > 1 file changed, 23 insertions(+) > > We have 3 kinds of submodule (or more?): > 1/ required to *build* QEMU > 2/ required to *test* QEMU > 3/ only here for satisfies license of firmware blobs shipped with QEMU. > > IIUC, long-term we want to move 3/ in another repository. > > Could we only set "recurse=true" for 1/ ? > > What is your use-case? Do we need it also for 2/ ?
I think if we're going to change the git handling of submodules from the default, it's probably going to be less confusing if all our submodules behave the same way, rather than some being the git-default and some the recurse=true behaviour. Assuming there's no reason why we would need some submodules to keep the recurse=false behaviour, of course... -- PMM
