On Fri, Sep 30, 2022 at 04:22:21PM +0200, David Hildenbrand wrote: > On 30.09.22 15:58, Gerd Hoffmann wrote: > > Drop legacy ids for virtio 1.0 devices, they are not needed > > and will be overridden anyway by generic virtio pci code. > > > > Improve modern virtio id documentation. > > > > Gerd Hoffmann (5): > > pci-ids: drop PCI_DEVICE_ID_VIRTIO_IOMMU > > pci-ids: drop PCI_DEVICE_ID_VIRTIO_MEM > > I remember that for some weird reason, this was required for Linux to > actually make use of the device. I never figured out why -- maybe that > changed.
Looking at 'info pci' the mem + pmem devices look identical with and without this series ... Bus 0, device 3, function 0: Class 0255: PCI device 1af4:1058 PCI subsystem 1af4:1100 IRQ 11, pin A BAR4: 64 bit prefetchable memory at 0xfe000000 [0xfe003fff]. id "" Bus 0, device 4, function 0: Class 0255: PCI device 1af4:105b PCI subsystem 1af4:1100 IRQ 10, pin A BAR4: 64 bit prefetchable memory at 0xfe004000 [0xfe007fff]. id "" ... and the PCI ID conforms virtio 1.0 (aka 0x1040 + virtio id). take care, Gerd