> > diff --git a/hw/virtio/virtio-iommu-pci.c b/hw/virtio/virtio-iommu-pci.c > > index 844d64770406..79ea8334f04e 100644 > > --- a/hw/virtio/virtio-iommu-pci.c > > +++ b/hw/virtio/virtio-iommu-pci.c > > @@ -74,8 +74,6 @@ static void virtio_iommu_pci_class_init(ObjectClass > > *klass, void *data) > > k->realize = virtio_iommu_pci_realize; > > set_bit(DEVICE_CATEGORY_MISC, dc->categories); > > device_class_set_props(dc, virtio_iommu_pci_properties); > > - pcidev_k->vendor_id = PCI_VENDOR_ID_REDHAT_QUMRANET; > > - pcidev_k->device_id = PCI_DEVICE_ID_VIRTIO_IOMMU; > > pcidev_k->revision = VIRTIO_PCI_ABI_VERSION; > > pcidev_k->class_id = PCI_CLASS_OTHERS; > > dc->hotpluggable = false; > > So does this mean: > * these ID values on the device were never used, because some > other code always overwrites them with the 'modern' ID values?
Yes. > If so, what is that other code? searching ... virtio_pci_device_plugged() does it. grep for virtio_bus_get_vdev_id to find the exact place. Guess I should send v3 with that added to the commit messages. > * this is a change in behaviour? No. take care, Gerd
