On Mittwoch, 24. August 2022 17:11:16 CEST Thomas Huth wrote: > At the point in time we're going to release QEMU 7.2, all supported > host OS distributions will have a libslirp package available, so > there is no need anymore for us to ship the slirp submodule. Thus > let's clean up the related tests and finally remove the submodule now. > > v2: > - Added patches to clean up and adapt the tests > - Rebased the removal patch to the latest version of the master branch > > Thomas Huth (6): > tests/docker: Update the debian-all-test-cross container to Debian 11 > tests/vm: Add libslirp to the VM tests > tests/lcitool/libvirt-ci: Update the lcitool module to the latest > version > tests: Refresh dockerfiles and FreeBSD vars with lcitool > tests/avocado: Do not run tests that require libslirp if it is not > available > Remove the slirp submodule (i.e. compile only with an external > libslirp)
And I was wondering (bisecting) why network silently stopped working here. While I understand the motivation for this change, it's probably not a user friendly situation to just silently decease functionality. As slirp was the default networking (i.e. not just some exotic QEMU feature), wouldn't it make sense then to make missing libslirp a build-time error by default? Best regards, Christian Schoenebeck
