Hi, This new version contains all changes proposed during the review process, all of them done in the patch that introduces dumpdtb.
Other changes made: - Patch 14/14, the one that introduces the command, is now patch 1. This change is to make the other machine patches referencing 'dumpdtb QMP/HMP' to reference an existing command. - added two new patches based on Philippe's feedback: patch 2 and patch 4. Mandatory patch pending review: patch 2 Optional machine patches pending review: 3, 4, 5, 7, 16 Changes from v7: - patch 14: switched to start of the series, now patch 1 - patch 1: - changed hmp-commands.hx help to: "dump the FDT in dtb format to 'filename'" - changed 'filename' to *filename* - changed filename description in machine.json to "name of the binary FDT file to be created" - changed 'size' to uint32_t - added a g_assert() for FDT size == zero - added a success message in hmp_dumpdtb() - patch 2 (new): - free ms->fdt in machine_finalize() - patch 4 (new): - assign ms->fdt in boston_mach_init() - v7 link: https://lists.gnu.org/archive/html/qemu-devel/2022-09/msg01350.html Daniel Henrique Barboza (16): qmp/hmp, device_tree.c: introduce dumpdtb hw/core: free ms->fdt in machine_finalize() hw/arm: do not free machine->fdt in arm_load_dtb() hw/mips: set machine->fdt in boston_mach_init() hw/microblaze: set machine->fdt in microblaze_load_dtb() hw/nios2: set machine->fdt in nios2_load_dtb() hw/ppc: set machine->fdt in ppce500_load_device_tree() hw/ppc: set machine->fdt in bamboo_load_device_tree() hw/ppc: set machine->fdt in sam460ex_load_device_tree() hw/ppc: set machine->fdt in xilinx_load_device_tree() hw/ppc: set machine->fdt in pegasos2_machine_reset() hw/ppc: set machine->fdt in pnv_reset() hw/ppc: set machine->fdt in spapr machine hw/riscv: set machine->fdt in sifive_u_machine_init() hw/riscv: set machine->fdt in spike_board_init() hw/xtensa: set machine->fdt in xtfpga_init() hmp-commands.hx | 15 +++++++++++++++ hw/arm/boot.c | 3 ++- hw/core/machine.c | 1 + hw/microblaze/boot.c | 8 +++++++- hw/microblaze/meson.build | 2 +- hw/mips/boston.c | 5 ++++- hw/nios2/boot.c | 8 +++++++- hw/nios2/meson.build | 2 +- hw/ppc/e500.c | 13 ++++++++++++- hw/ppc/pegasos2.c | 4 ++++ hw/ppc/pnv.c | 8 +++++++- hw/ppc/ppc440_bamboo.c | 25 +++++++++++++----------- hw/ppc/sam460ex.c | 21 ++++++++++---------- hw/ppc/spapr.c | 3 +++ hw/ppc/spapr_hcall.c | 8 ++++++++ hw/ppc/virtex_ml507.c | 25 +++++++++++++----------- hw/riscv/sifive_u.c | 3 +++ hw/riscv/spike.c | 6 ++++++ hw/xtensa/meson.build | 2 +- hw/xtensa/xtfpga.c | 6 +++++- include/sysemu/device_tree.h | 1 + monitor/misc.c | 1 + qapi/machine.json | 18 ++++++++++++++++++ softmmu/device_tree.c | 37 ++++++++++++++++++++++++++++++++++++ 24 files changed, 183 insertions(+), 42 deletions(-) -- 2.37.3