Re: [PATCH v4 29/53] semihosting: Split out semihost_sys_read

[Richard Henderson]

On 6/22/22 12:25, Luc Michel wrote:

+static void common_semi_rw_cb(CPUState *cs, target_ulong ret, target_ulong err)
+{
+    /* Recover the original length from the third argument. */
+    CPUArchState *env G_GNUC_UNUSED = cs->env_ptr;
+    target_ulong args = common_semi_arg(cs, 1);
+    target_ulong arg2;
+    GET_ARG(2);
+
+    if (err) {
+ do_fault:

Leftover label?

No, the compiler would have warned.  It's used by GET_ARG.

r~