On 5/30/22 05:44, Peter Maydell wrote:
  G_NORETURN void raise_exception(CPUARMState *env, uint32_t excp,
-                                uint32_t syndrome, uint32_t target_el);
+                                uint32_t syndrome, uint32_t cur_or_target_el);

"cur_or_target_el" is odd, because it's mixing what the architecture
sets up as two distinct things: the state the exception is
"taken from", and the state the exception is "taken to". I was
hoping this was just a temporary thing for the purposes of the
refactoring and it would go away near the end of the series, but
it doesn't seem to.

No, sorry. Most of the time it's cur_el, except from cpregs, where we get directed to a specific higher el. There may be some way to split the helpers...

I'll have another go at this reorg this week. If it still doesn't feel cleaner, we can drop it, and I'll make some changes to the SME patch set building on this.


r~

Reply via email to