From: Marc-André Lureau <marcandre.lur...@redhat.com>
Hi,
More preliminary cleanups before a series to make qemu-ga a meson subproject().
v5:
- drop Error argument from qga_open_cloexec()
- add r-b tags
v4:
- remove some unnecessary ERRP_GUARD()
- open-code some g_clear_pointer()
- don't export qemu_open_cloexec, introduce qga_open_cloexec instead
- some formatting improvements
- add new r-b tags
v3:
- changed error_report_err() back to g_critical()
- added "qga: make build_fs_mount_list() return a bool"
- replaced g_clear_pointer() usage by open-coded version
- dropped needless g_autoptr(GError) in tests
- rebased, (dropped "include: adjust header guards after renaming")
- some commit message rewording
- added r-b tags
v2:
- drop "compiler.h: add QEMU_{BEGIN,END}_IGNORE_INITIALIZER_OVERRIDES",
"qobject/json-lexer: disable -Winitializer-overrides warnings" &
"qapi/error: add g_autoptr(Error) support" and adjust related code.
- add "test/qga: use g_auto wherever sensible"
- add r-b tags
Marc-André Lureau (15):
include: move qemu_*_exec_dir() to cutils
util/win32: simplify qemu_get_local_state_dir()
tests: make libqmp buildable for win32
qga: flatten safe_open_or_create()
qga: add qga_open_cloexec() helper
qga: use qga_open_cloexec() for safe_open_or_create()
qga: throw an Error in ga_channel_open()
qga: replace qemu_open_old() with qga_open_cloexec()
qga: make build_fs_mount_list() return a bool
test/qga: use G_TEST_DIR to locate os-release test file
qga/wixl: prefer variables over environment
qga/wixl: require Mingw_bin
qga/wixl: simplify some pre-processing
qga/wixl: replace QEMU_GA_MSI_MINGW_BIN_PATH with glib bindir
test/qga: use g_auto wherever sensible
configure | 9 +-
meson.build | 5 +-
include/qemu/cutils.h | 7 ++
include/qemu/osdep.h | 8 --
qga/cutils.h | 8 ++
tests/qtest/libqmp.h | 2 +
qemu-io.c | 1 +
qga/channel-posix.c | 55 +++++-----
qga/commands-posix.c | 154 +++++++++++++--------------
qga/cutils.c | 33 ++++++
storage-daemon/qemu-storage-daemon.c | 1 +
tests/qtest/fuzz/fuzz.c | 1 +
tests/qtest/libqmp.c | 34 +++++-
tests/unit/test-qga.c | 130 ++++++++--------------
util/cutils.c | 108 +++++++++++++++++++
util/oslib-posix.c | 81 --------------
util/oslib-win32.c | 53 +--------
qga/installer/qemu-ga.wxs | 83 +++++----------
qga/meson.build | 12 +--
19 files changed, 385 insertions(+), 400 deletions(-)
create mode 100644 qga/cutils.h
create mode 100644 qga/cutils.c
--
2.36.1
