On Sat, 21 May 2022 at 01:04, Richard Henderson
<richard.hender...@linaro.org> wrote:
>
> We have two copies of these structures, and require them
> in semihosting/ going forward.
>
> Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
> ---
> include/exec/gdbstub.h | 25 +++++++++++++++++++++++++
> target/m68k/m68k-semi.c | 30 +++---------------------------
> target/nios2/nios2-semi.c | 30 +++---------------------------
> 3 files changed, 31 insertions(+), 54 deletions(-)
>
> diff --git a/include/exec/gdbstub.h b/include/exec/gdbstub.h
> index 2aaba9c723..33a262a5a3 100644
> --- a/include/exec/gdbstub.h
> +++ b/include/exec/gdbstub.h
> @@ -20,6 +20,31 @@
> #define GDB_O_TRUNC 0x400
> #define GDB_O_EXCL 0x800
>
> +/* For gdb file i/o stat/fstat. */
> +typedef uint32_t gdb_mode_t;
> +typedef uint32_t gdb_time_t;
> +
> +struct gdb_stat {
> + uint32_t gdb_st_dev; /* device */
> + uint32_t gdb_st_ino; /* inode */
> + gdb_mode_t gdb_st_mode; /* protection */
> + uint32_t gdb_st_nlink; /* number of hard links */
> + uint32_t gdb_st_uid; /* user ID of owner */
> + uint32_t gdb_st_gid; /* group ID of owner */
> + uint32_t gdb_st_rdev; /* device type (if inode device) */
> + uint64_t gdb_st_size; /* total size, in bytes */
> + uint64_t gdb_st_blksize; /* blocksize for filesystem I/O */
> + uint64_t gdb_st_blocks; /* number of blocks allocated */
> + gdb_time_t gdb_st_atime; /* time of last access */
> + gdb_time_t gdb_st_mtime; /* time of last modification */
> + gdb_time_t gdb_st_ctime; /* time of last change */
> +} QEMU_PACKED;
> +
> +struct gdb_timeval {
> + gdb_time_t tv_sec; /* second */
> + uint64_t tv_usec; /* microsecond */
> +} QEMU_PACKED;
As an aside,
https://sourceware.org/gdb/onlinedocs/gdb/struct-timeval.html#struct-timeval
says "this structure is of size 8 bytes", but looking at the gdb sources
our definition here is correct and it's 12 bytes (not 8 as the text says
and not 16 as you might expect from the C struct in the docs...)
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
thanks
-- PMM
