On Sat, 21 May 2022 at 01:04, Richard Henderson <richard.hender...@linaro.org> wrote: > > There were 3 copies of these flags. Place them in the > file with gdb_do_syscall, with which they belong. > > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > include/exec/gdbstub.h | 10 ++++++++++ > semihosting/arm-compat-semi.c | 8 -------- > target/m68k/m68k-semi.c | 8 -------- > target/nios2/nios2-semi.c | 8 -------- > 4 files changed, 10 insertions(+), 24 deletions(-)
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Separately: > +#define GDB_O_BINARY 0 The gdb remote protocol doesn't define an O_BINARY: https://sourceware.org/gdb/onlinedocs/gdb/Open-Flags.html#Open-Flags and files are always opened in binary mode: https://sourceware.org/git/?p=binutils-gdb.git;a=blob;f=gdb/remote-fileio.c;h=fe191fb6069a53a3844656a81e77069afa781946;hb=HEAD#l122 so we should probably drop our definition and use of GDB_O_BINARY. thanks -- PMM
