+Robert On Wed, May 11, 2022 at 11:30 AM Daniel P. Berrangé <berra...@redhat.com> wrote: > > On Tue, May 10, 2022 at 09:56:12PM +0200, Thomas Huth wrote: > > According to our "Supported build platforms" policy, we now do not support > > Ubuntu 18.04 anymore. Remove the related files and entries from our CI. > > > > Signed-off-by: Thomas Huth <th...@redhat.com> > > --- > > Seems like nobody touched the 18.04-based tests/vm/ubuntu* files in a > > very long time, so I assume these are not used anymore and can completely > > be removed now. > > Or it could mean that they are working fine and so haven't needed > changes...
Yes :) > The cross-compiler container envs give us build coverage for > non-x86, but the VMs give developers on x86 the ability to > actually run the unit tests / I/O tests. Personally I've > never used them, but someone might be ? I'd say Peter / Alex / Gerd / myself are using it from time to time. It has been proven useful to test x86_64 on aarch64, so I'd rather upgrade it. Robert, what do you think? > I'd suggest splitting this patch into several pieces. One > to fixup all the custom runner related pieces to remove > references to 18.04. One to delete the 18.04 container > related pieces. One to delete the 18.04 VM related pieces. > > If you're adventurous, add a 22.04 container since that > is released now and in the QEMU platform target scope. > > > > > .gitlab-ci.d/containers.yml | 5 - > > .../custom-runners/ubuntu-20.04-aarch32.yml | 2 +- > > .../custom-runners/ubuntu-20.04-aarch64.yml | 2 +- > > scripts/ci/setup/build-environment.yml | 14 +- > > tests/docker/dockerfiles/ubuntu1804.docker | 144 ------------------ > > tests/lcitool/refresh | 7 - > > tests/vm/ubuntu.aarch64 | 68 --------- > > tests/vm/ubuntu.i386 | 40 ----- > > tests/vm/ubuntuvm.py | 60 -------- > > 9 files changed, 4 insertions(+), 338 deletions(-) > > delete mode 100644 tests/docker/dockerfiles/ubuntu1804.docker > > delete mode 100755 tests/vm/ubuntu.aarch64 > > delete mode 100755 tests/vm/ubuntu.i386 > > delete mode 100644 tests/vm/ubuntuvm.py
