On 5/5/22 12:59, Kevin Wolf wrote:
Am 05.05.2022 um 11:28 hat Paolo Bonzini geschrieben:
Or actually, it could just unconditionally run 'make check-venv' by
itself, which is probably easier to implement than checking the
dependencies and more convenient for the user, too.
One small complication is that on BSD systems the binary is actually
called "gmake", so you'd have to pass the variable somehow
I guess we could just export $MAKE as an environment variable?
That would work when invoked by "make", but then that's the case in
which the venv would be there anyway.
For the other case, it would have to parse config-host.mak and/or
reintroduce something like tests/qemu-iotests/common.env. All in all it
seems like an unnecessary complication over just printing a clear and
polite error message.
Paolo
