Am 05.05.2022 um 11:28 hat Paolo Bonzini geschrieben: > On 5/5/22 10:51, Kevin Wolf wrote: > > If not, I guess it would be enough if iotests just checks that the venv > > exists and all of the dependencies are there in the right version and > > error out if not, telling the user to run 'make check-venv'. > > > > Or actually, it could just unconditionally run 'make check-venv' by > > itself, which is probably easier to implement than checking the > > dependencies and more convenient for the user, too. > > Note that you would still have to add a 'check-block: check-venv' > dependency in the Makefile, otherwise two "instances" of check-venv > could run in parallel.
Good point. I only considered manual invocations, but for 'make check-block' that sounds right. > One small complication is that on BSD systems the binary is actually > called "gmake", so you'd have to pass the variable somehow I guess we could just export $MAKE as an environment variable? Kevin
