On Tue, May 03, 2022 at 04:21:44PM -0700, Dongwon Kim wrote: > On Tue, May 03, 2022 at 10:12:43AM +0100, Daniel P. Berrangé wrote: > > On Thu, Apr 28, 2022 at 04:13:03PM -0700, Dongwon Kim wrote: > > > With "detach-all=on" for display, QEMU starts with all VC windows > > > detached automatically. > > > > > > If used with "full-screen=on", it places individual windows (from > > > top window) starting from monitor 0 or monitor n in case monitor=n. > > > > > > In case # mon < # VCs, only same number of VCs as # mon will be sent to > > > the monitors for full-screen while others are remaining in windowed-mode. > > > > > > Target monitor number for individual VC is rotated in case monitor=n > > > (n != 0) (e.g. if monitor=1 and # VCs = 2, the top window will be > > > full-screened on monitor 1 and top second window will be full-screened > > > on monitor 0.) > > > > I tend to wonder whether we actually need this at all, as opposed > > to just changing QEMU's behaviour by default. > > > > It makes sense to have tabs per-VC for the things like the HMP > > console, serial ports, etc, but I think graphical video outputs > > should always be displayed as multiple windows. Putting graphical > > outputs as tabs rather defeats the purpose of having multiple > > outputs IMHO. > > > > IOW, why won't we just create 1 gtk window per graphical output > > all the time. > > I got your point but I think this requires changes in the > policy, which I guess need community-wide agreement. Why don't we move > on with this new option and at the same time start the discussion?
Once we add a CLI option is it is more complicated to remove it again later. So if we don't actually need it, it is better not to add it in the first place. > One more point is, I tried to find out but I couldn't think of any good way > to distinguish between guest output consoles and other consoles. Do you > have any thought on this? There's a helper: bool qemu_console_is_graphic(QemuConsole *con); With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
