* Daniel P. Berrangé (berra...@redhat.com) wrote: > This significantly expands the migration test suite to cover testing > with TLS over TCP and UNIX sockets, with both PSK (pre shared keys) > and x509 credentials, and for both single and multifd scenarios. > > It identified one bug in handling PSK credentials with UNIX sockets, > but other than that everything was operating as expected. > > To minimize the impact on code duplication alopt of refactoring is > done of the migration tests to introduce a common helper for running > the migration process. The various tests mostly just have to provide > a callback to set a few parameters/capabilities before migration > starts, and sometimes a callback to cleanup or validate after > completion/failure.
I've queued: tests: ensure migration status isn't reported as failed tests: convert multifd migration tests to use common helper tests: convert XBZRLE migration test to use common helper tests: fix encoding of IP addresses in x509 certs I'd appreciate some TLS people to review the other parts. Dave > Changed in v3: > > - Trivial rebase dropping already merged patches > > Changed in v2: > > - Use structs to pass around most parameters > - Hide expected errors from stderr > > Daniel P. Berrangé (9): > tests: fix encoding of IP addresses in x509 certs > tests: add more helper macros for creating TLS x509 certs > tests: add migration tests of TLS with PSK credentials > tests: add migration tests of TLS with x509 credentials > tests: convert XBZRLE migration test to use common helper > tests: convert multifd migration tests to use common helper > tests: add multifd migration tests of TLS with PSK credentials > tests: add multifd migration tests of TLS with x509 credentials > tests: ensure migration status isn't reported as failed > > meson.build | 1 + > tests/qtest/meson.build | 12 +- > tests/qtest/migration-helpers.c | 13 + > tests/qtest/migration-helpers.h | 1 + > tests/qtest/migration-test.c | 866 ++++++++++++++++++++++++--- > tests/unit/crypto-tls-psk-helpers.c | 18 +- > tests/unit/crypto-tls-psk-helpers.h | 1 + > tests/unit/crypto-tls-x509-helpers.c | 16 +- > tests/unit/crypto-tls-x509-helpers.h | 53 ++ > tests/unit/test-crypto-tlssession.c | 11 +- > 10 files changed, 897 insertions(+), 95 deletions(-) > > -- > 2.35.1 > > -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
