On Tue, Apr 26, 2022 at 5:50 PM Richard Henderson <[email protected]> wrote: > > On 4/26/22 16:08, Atish Patra wrote: > > + .num_offset = vmstate_offset_value(_state, _field_num, uint32_t),\ > ... > > } else if (field->flags & VMS_VARRAY_UINT32) { > > n_elems = *(uint32_t *)(opaque + field->num_offset); > > + } else if (field->flags & VMS_VARRAY_UINT64) { > > + n_elems = *(uint64_t *)(opaque + field->num_offset); > > Offset type mismatch. Since num_harts is uint32_t, I don't believe you need > this patch at > all. >
Ahh yes. You are right. I read the function description wrong and assumed that VMSTATE_VARRAY_UINT32 creates an variable array of uint32_t elements only. Thanks for the clarification. > > r~
