On 4/26/22 02:27, marcandre.lur...@redhat.com wrote:
From: Marc-André Lureau <marcandre.lur...@redhat.com>Suggested-by: Daniel P. Berrangé <berra...@redhat.com> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> --- qga/commands-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 77f4672ca2c9..094487c2c395 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -2529,7 +2529,7 @@ void qmp_guest_set_user_password(const char *username, goto out; }- if (pipe(datafd) < 0) {+ if (!g_unix_open_pipe(datafd, FD_CLOEXEC, NULL)) { error_setg(errp, "cannot create pipe FDs"); goto out; }
This looks wrong, since the next thing that happens is fork+execl. r~
