On Sun, 17 Apr 2022 at 19:21, Richard Henderson <richard.hender...@linaro.org> wrote: > > Give this enum a name and use in ARMCPRegInfo and add_cpreg_to_hashtable. > Add the enumerator ARM_CP_SECSTATE_BOTH to clarify how 0 > is handled in define_one_arm_cp_reg_with_opaque. > > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > target/arm/cpregs.h | 7 ++++--- > target/arm/helper.c | 3 ++- > 2 files changed, 6 insertions(+), 4 deletions(-)
Maybe also change the "default" in the switch in define_one_arm_cp_reg_with_opaque() to "case ARM_CP_SECSTATE_BOTH" ? Either way, Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM