On Sun, 17 Apr 2022 at 19:15, Richard Henderson <richard.hender...@linaro.org> wrote: > > Create a typedef as well, and use it in ARMCPRegInfo. > This won't be perfect for debugging, but it'll nicely > display the most common cases. > > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > ---
> @@ -8741,8 +8741,7 @@ void define_one_arm_cp_reg_with_opaque(ARMCPU *cpu, > break; > default: > /* broken reginfo with out-of-range opc1 */ > - assert(false); > - break; > + g_assert_not_reached(); > } > /* assert our permissions are not too lax (stricter is fine) */ > assert((r->access & ~mask) == 0); This part is an unrelated change and should be a separate patch. Otherwise Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM
