hi, > thanks for your patch, looks pretty good already, but there is a small > issue: Try for example: > > ./qemu-system-s390x -vga none > > ... and it will print the warning "qemu-system-s390x: warning: No vga device > is created", though the user only asked for no VGA device. This seems to > happen if a machine does not have any VGA device by default, but still > requests "-vga none" on the command line.
This can be solved by adding this condition : (vga_interface_type != VGA_NONE) > On 08/04/2022 12.45, Gautam Agrawal wrote: > > This patch is in regards to this > > issue:https://gitlab.com/qemu-project/qemu/-/issues/581#. > > Better write this right in front of your Signed-off-by line: > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/581 > > ... then the ticket will be automatically be closed once your patch gets > merged. > I apologize for this mistake > vga_interface_type is also used in hw/mips/fuloong2e.c and > hw/xenpv/xen_machine_pv.c ... do they need a change, too? I can definitely make similar changes in them too since they also specify the vga_interface_type, shall I proceed with this? > This will trigger a warning from the scripts/checkpatch.pl script: > > ERROR: do not initialise globals to 0 or NULL > #238: FILE: softmmu/globals.c:43: > +bool vga_interface_created = false; Could you kindly suggest a better approach to this than creating a global variable. > I'm not a native speaker, and maybe it's just a matter of taste, but I'd > rather say it in past tense: "No VGA device has been created" I will correct the warning message, as suggested by Peter Maydell. Regards, Gautam Agrawal
