On Mon, 25 Apr 2022 at 06:47, Markus Armbruster <arm...@redhat.com> wrote: > > Gautam Agrawal <gautamnagra...@gmail.com> writes: > > > This patch is in regards to this > > issue:https://gitlab.com/qemu-project/qemu/-/issues/581#. > > A global boolean variable "vga_interface_created"(declared in > > softmmu/globals.c) > > has been used to track the creation of vga interface. If the vga flag is > > passed in the command > > line "default_vga"(declared in softmmu/vl.c) variable is set to 0. To warn > > user, the condition > > checks if vga_interface_created is false and default_vga is equal to 0. > > > > The warning "No vga device is created" is logged if vga flag is passed > > but no vga device is created. This patch has been tested for > > x86_64, i386, sparc, sparc64 and arm boards. > > Suggest to include a reproducer here, e.g. > > $ qemu-system-x86_64 -S -display none -M microvm -vga std > qemu-system-x86_64: warning: No vga device is created > > See below for my critique of the warning message.
You're reviewing an old version of this patch -- the newer versions improve the message... -- PMM
