I've reviewed all changes,  looks good.
Ran all of my own tests including vstrs, all passed.

Thank you for all reviews and changes here.

- David Miller

On Mon, Mar 7, 2022 at 8:54 PM Richard Henderson <
richard.hender...@linaro.org> wrote:

> Hi David,
>
> I've split up the patches a bit, made some improvements to
> the shifts and reversals, and fixed a few bugs.
>
> Please especially review vector string search, as that is
> has had major changes.
>
>
> r~
>
>
> David Miller (9):
>   target/s390x: vxeh2: vector convert short/32b
>   target/s390x: vxeh2: vector string search
>   target/s390x: vxeh2: Update for changes to vector shifts
>   target/s390x: vxeh2: vector shift double by bit
>   target/s390x: vxeh2: vector {load, store} elements reversed
>   target/s390x: vxeh2: vector {load, store} byte reversed elements
>   target/s390x: vxeh2: vector {load, store} byte reversed element
>   target/s390x: add S390_FEAT_VECTOR_ENH2 to cpu max
>   tests/tcg/s390x: Tests for Vector Enhancements Facility 2
>
> Richard Henderson (2):
>   tcg: Implement tcg_gen_{h,w}swap_{i32,i64}
>   target/s390x: Fix writeback to v1 in helper_vstl
>
>  include/tcg/tcg-op.h                 |   6 +
>  target/s390x/helper.h                |  13 +
>  target/s390x/gen-features.c          |   2 +
>  target/s390x/tcg/translate.c         |   3 +-
>  target/s390x/tcg/vec_fpu_helper.c    |  31 ++
>  target/s390x/tcg/vec_helper.c        |   2 -
>  target/s390x/tcg/vec_int_helper.c    |  58 ++++
>  target/s390x/tcg/vec_string_helper.c | 101 ++++++
>  tcg/tcg-op.c                         |  30 ++
>  tests/tcg/s390x/vxeh2_vcvt.c         |  97 ++++++
>  tests/tcg/s390x/vxeh2_vlstr.c        | 146 +++++++++
>  tests/tcg/s390x/vxeh2_vs.c           |  91 ++++++
>  target/s390x/tcg/translate_vx.c.inc  | 442 ++++++++++++++++++++++++---
>  target/s390x/tcg/insn-data.def       |  40 ++-
>  tests/tcg/s390x/Makefile.target      |   8 +
>  15 files changed, 1018 insertions(+), 52 deletions(-)
>  create mode 100644 tests/tcg/s390x/vxeh2_vcvt.c
>  create mode 100644 tests/tcg/s390x/vxeh2_vlstr.c
>  create mode 100644 tests/tcg/s390x/vxeh2_vs.c
>
> --
> 2.25.1
>
>

Reply via email to