When we build our Windows installer, there are some warnings
generated:
warning 7998: ANSI targets are deprecated
warning 6000: unknown variable/constant "{Section_i386}" detected, ignoring
(macro:_==:1)
warning 6000: unknown variable/constant "{Section_i386w}" detected, ignoring
(macro:_==:1)
(you can see these in the relevant gitlab CI job logs).
This series fixes them; one of them is flagging up an actual bug.
It also fixes the basically-random order we were listing the
emulators in.
I noticed while working on this that we list the emulators in
basically random order (whatever glob.glob() returns); so I start off
with fixing that in patch 1 by adding a sorted() call.
The "ANSI targets" warning is just complaining that we don't declare
our installer to be a Unicode installer. Doing so silences the
warning, and would allow us to include non-ASCII text in messages
(which we don't currently need). The resulting installer won't run on
Win95/98/ME, but we don't support those anyway. Fixed in patch 2.
The "unknown variable" warnings are about a real problem: we generate
installer sections for each emulator executable using the nsis.py
script, but still have a fixed and very out of date list of mouse-over
description text in the qemu.nsi file. So if you build the installer
for a configuration which doesn't include either i386 or alpha then
you get warnings about the mouse-over text defined for the
non-existent sections; and we don't provide any mouse-over text for
anything other than i386 and alpha. Patch 3 makes the nsis.py script
also generate a second installer script fragment with mouseover text
for all and only the sections it generates in the existing fragment.
The generated text is not particularly pretty or informative, but at
least it's there and clarifies the "GUI" vs "not GUI" versions of each
executable.
Tested by building the installer executable via the gitlab
'cross-win64-system' CI job and test-installing it on a Windows 10 VM
I had to hand.
thanks
-- PMM
Peter Maydell (3):
nsis installer: List emulators in alphabetical order
nsis installer: Suppress "ANSI targets are deprecated" warning
nsis installer: Fix mouse-over descriptions for emulators
qemu.nsi | 8 ++++----
scripts/nsis.py | 17 ++++++++++++++---
2 files changed, 18 insertions(+), 7 deletions(-)
--
2.25.1
