On 23.02.22 12:49, Thomas Huth wrote: > On 23/02/2022 11.54, David Hildenbrand wrote: >> On 23.02.22 11:44, Thomas Huth wrote: >>> On 18/02/2022 00.17, David Miller wrote: >>>> Signed-off-by: David Miller <dmiller...@gmail.com> >>>> --- >>>> tests/tcg/s390x/mie3-compl.c | 21 +++++++++++---------- >>>> tests/tcg/s390x/mie3-mvcrl.c | 2 +- >>>> tests/tcg/s390x/mie3-sel.c | 6 +++--- >>>> 3 files changed, 15 insertions(+), 14 deletions(-) > ... >>> >>> Reviewed-by: Thomas Huth <th...@redhat.com> >>> >>> ... maybe best to squash this into the previous patch, though (I can do that >>> when picking up the patch if you agree - no need to resend for this). >>> >> >> Do we need this with my debian11 container change? > > I just tried without, but this breaks on s390x hosts with older compilers, > where the TCG tests are run without a container: > > https://app.travis-ci.com/github/huth/qemu/jobs/560854945#L12875 > > Since Ubuntu 20.04 is still a supported s390x build system for QEMU, I > assume it's best if we squash the .insn patch?
But then, the "-march=z15 -m64" in the previous patch is also unsafe. -- Thanks, David / dhildenb
