On 08.02.22 11:13, Thomas Huth wrote:
For better integration of the iotests into the meson build system, it
would be very helpful to get the list of the tests in the "auto" group
during the "configure" step already. However, "check -n -g auto"
currently only works if the binaries have already been built. Re-order
the code in the "check" a little bit so that we can use the -n option
without building the binaries first.
Signed-off-by: Thomas Huth <th...@redhat.com>
---
tests/qemu-iotests/check | 52 ++++++++++++++++++++++------------------
1 file changed, 29 insertions(+), 23 deletions(-)
I don’t love how this patch completely separates dry_run from running
the tests, and how finding source_iotests is replicated from
testenv.py. For the latter, we should at least assert somewhere that
source_iotests == env.source_iotests.
Wouldn’t it instead be possible to pass args.dry_run to TestEnv and have
it just skip all build-dir-related stuff, which I think is just the
self.init_binaries() call (and perhaps the self.qemu_prog check in the
`for suffix, machine in machine_map` loop)?
Hanna
