On Thu, 13 Jan 2022 at 11:48, Peter Maydell <peter.mayd...@linaro.org> wrote: > > On Mon, 10 Jan 2022 at 21:47, Patrick Venture <vent...@google.com> wrote: > > > > This patch series introduces a new i2c module, namely the designware one > > and further enables this (optionally) for the virt-arm machine. > > > > Chris Rauer (2): > > hw/i2c: Add designware i2c controller. > > hw/arm: Enable smbus on arm virt machine. > > I need to see a pretty strong justification for why we > should be adding new kinds of devices to the virt machine, > given that it increases complexity and potential attack > surface for using it with KVM; this cover letter doesn't > seem to provide any...
Forgot to mention, but my prefered approach for providing an i2c controller on the virt board would be to have a PCI i2c controller: that way users who do need it can plug it in with a -device command line option, and users who don't need it never have to worry about it. (We seem to have an ICH9-SMB PCI device already; I have no idea if it's suitable.) thanks -- PMM
