Am 11.11.2011 16:07, schrieb 陳韋任: > On Fri, Nov 11, 2011 at 03:02:16PM +0000, Peter Maydell wrote: >> On 11 November 2011 14:53, Chen Wei-Ren (陳韋任) <che...@iis.sinica.edu.tw> >> wrote: >>> From: Chen Wei-Ren <che...@iis.sinica.edu.tw> >>> >>> Remove qruncom target from the Makefile file since we have >>> removed libqemu example (qruncom.c). >> >> This should be done before the patch removing qruncom.c, not after. >> Or do both in the same patch. > > I'll reverse the order next time. Is there a rule of thumb about how > to order those patches?
The logic goes like this: Every single patch should build / work. If you remove the sources, the Makefile rule no longer works. If you remove the Makefile rule, the sources are not used. Therefore best just squash these two commits together. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
