> This commit isn't doing what the commit message claims it does. > > What you're actually removing is a set of manually inserted > dependencies of some object files on their source files and > on cpu.h. There is already no libqemu target in this makefile. > What you maybe wanted to remove is just the now out of date > comment line?
I thought the lines below "# libqemu" is related to libqemu.a , but it's apparently not. > Now, I think those manually inserted dependencies shouldn't > be there, because the autogenerated .d files already cover > the dependencies they specify as far as I can tell. You mean those *.d file under the build directory? > But that would be a different commit entirely.) I'll exclude those manually inserted dependencies from this series next time. Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-2788-3799 #1667 Homepage: http://people.cs.nctu.edu.tw/~chenwj/