On Thu, Dec 30, 2021 at 4:50 AM WANG Xuerui <i.q...@xen0n.name> wrote: > > Hi, > > On 12/30/21 11:11, gaosong wrote: > > HI, > > On 2021/12/21 下午1:41, WANG Xuerui wrote: > > + case 0b001110: /* indexed, atomic, bounds-checking memory operations */ > + uint32_t sel = (insn >> 15) & 0b11111111111; > + > + switch (sel) { > + case 0b00000100000: /* stx.b */ > + case 0b00000101000: /* stx.h */ > + case 0b00000110000: /* stx.w */ > + case 0b00000111000: /* stx.d */ > + case 0b00001110000: /* fstx.s */ > + case 0b00001111000: /* fstx.d */ > + case 0b00011101100: /* fstgt.s */ > + case 0b00011101101: /* fstgt.d */ > + case 0b00011101110: /* fstle.s */ > + case 0b00011101111: /* fstle.d */ > + case 0b00011111000: /* stgt.b */ > + case 0b00011111001: /* stgt.h */ > + case 0b00011111010: /* stgt.w */ > + case 0b00011111011: /* stgt.d */ > + case 0b00011111100: /* stle.b */ > + case 0b00011111101: /* stle.h */ > + case 0b00011111110: /* stle.w */ > + case 0b00011111111: /* stle.d */ > + case 0b00011000000 ... 0b00011100011: /* am* insns */ > + return true; > + } > + break; > + } > > We build qemu-x86_64 on LoongArch machine, but got an error, > > ../linux-user/host/loongarch64/host-signal.h:57:9: error: a label can only be > part of a statement and a declaration is not a statement > uint32_t sel = (insn >> 15) & 0b11111111111; > ^~~~~~~~ > > I think we should define 'sel' before: > > /* Detect store by reading the instruction at the program counter. */ > switch ((insn >> 26) & 0b111111) { > > or > case 0b001110: > > { > > uint32_t set = ...; > > ... > > } > > I can't reproduce the error on both my development machines (amd64 and > loongarch64), so I wonder if the issue is related to your particular setup > (i.e. compiler versions and such)?
I can reproduce, setup: Project version: 6.2.50 C compiler for the host machine: cc (gcc 8.3.0 "cc (Loongnix 8.3.0-6.lnd.vec.27) 8.3.0") C linker for the host machine: cc ld.bfd 2.31.1-system Host machine cpu family: loongarch64 Host machine cpu: loongarch64 C++ compiler for the host machine: c++ (gcc 8.3.0 "c++ (Loongnix 8.3.0-6.lnd.vec.27) 8.3.0") C++ linker for the host machine: c++ ld.bfd 2.31.1-system