Peter Xu <pet...@redhat.com> wrote: > On Tue, Dec 21, 2021 at 01:52:30PM +0100, Juan Quintela wrote: >> So printing it as %d is wrong. Notice that for the channel id, that >> is an uint8_t, but I changed it anyways for consistency. > > Just curious: uint_8 can always correctly converted to a int, so the patch > shouldn't have a functional change, right?
Yeap. My understanding of C promotion rules is that everything is promoted to int by default, if the size is smaller than positive part of it, that is ok. But once there, I reviewed all "%d", and if it was unsigned, I change it to "%u". >> Signed-off-by: Juan Quintela <quint...@redhat.com> >> Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> > > Reviewed-by: Peter Xu <pet...@redhat.com> Thanks, Juan.
